This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Apply negative rating on explicit ban #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
approved these changes
Apr 10, 2019
Contributor
|
I am about to test this. |
andresilva
approved these changes
Apr 10, 2019
Co-Authored-By: arkpar <[email protected]>
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Apply negative rating on explicit ban * Update core/network/src/service.rs Co-Authored-By: arkpar <[email protected]>
cmichi
pushed a commit
that referenced
this pull request
Apr 13, 2019
* Apply negative rating on explicit ban * Update core/network/src/service.rs Co-Authored-By: arkpar <[email protected]>
andresilva
pushed a commit
that referenced
this pull request
Apr 15, 2019
* Apply negative rating on explicit ban * Update core/network/src/service.rs Co-Authored-By: arkpar <[email protected]>
andresilva
pushed a commit
that referenced
this pull request
Apr 15, 2019
* Apply negative rating on explicit ban * Update core/network/src/service.rs Co-Authored-By: arkpar <[email protected]>
gavofyork
pushed a commit
that referenced
this pull request
Apr 16, 2019
* simplification of peerset api (#2123) * Introduction of PeersetHandle * integrate PeersetHandle with the rest of the codebase * fix compilation errors * more tests for peerset, fixed overwriting bug in add_reserved_peer * Slots data structure and bugfixes for peerset * bend to pressure * updated lru-cache to 0.1.2 and updated linked-hash-map to 0.5.2 * peerset discovered list is now a LinkedHashMap * fix review suggestions * split back Peerset and PeersetHandle * test for Peerset::discovered * applied review suggestions * fixes to peerset::incoming * peerset disconnects are all instantaneous * instantaneous drop in peerset finished * Peerset::set_reserved_only can also reconnect nodes * Peerset scores cache uses lru-cache * remove redundant function call and comment from Peerset::on_set_reserved_only * add_peer returns SlotState enum * apply review suggestions * is_reserved -> is_connected_and_reserved * Fix state inconsistency between handler and behaviour (#2220) * Fix state inconsistency between handler and behaviour * Fix the error! being in the wrong place * Apply negative rating on explicit ban (#2247) * Apply negative rating on explicit ban * Update core/network/src/service.rs Co-Authored-By: arkpar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores peer banning for e.g. being on a different chain, until this is properly implemented.