This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Extensible transactions (and tips) #3102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also Remove old extrinsic types.
gavofyork
added
the
A3-in_progress
Member
Author
|
CC @kianenigma |
gavofyork
changed the title
This was referenced Jul 14, 2019
kianenigma
reviewed
Jul 15, 2019
* Weight signed extension. * Revert a bit + test for check era. * Update Cargo.toml * Update node/cli/src/factory_impl.rs * Update node/executor/src/lib.rs * Update node/executor/src/lib.rs
This was referenced Jul 16, 2019
5 tasks
* working poc added. * some fixes. * Update doc. * Fix all tests + final logic. * more refactoring. * nits. * System block limit in bytes. * Silent the storage macro warnings. * More logic more tests. * Fix import. * Refactor names. * Fix build. * Update srml/balances/src/lib.rs * Final refactor.
…bstrate into gav-extensble-transactions
Contributor
|
I put some leftover tasks/todos/thoughts there myself. Except for the last one about removing |
kianenigma
added
A0-please_review
Member
Author
|
@kianenigma don't forget the issue for the TODO. then once it's reviewed by a third person is can be merged. |
jacogr
reviewed
Jul 22, 2019
Contributor
jacogr
left a comment
jacogr
left a comment
There was a problem hiding this comment.
Cannot review the code, however did e2e testing with the polkadot-js API against the v2 format and this branch (and also pulled it into the apps UI), and it def. works as expected. Immortals, mortals, payloads, all ok and verifies as expected. (And all aligned with the specification as detailed in the first comment)
Contributor
|
Merging by the end of today if no one else reacts. |
kianenigma
approved these changes
Jul 22, 2019
This was referenced Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of logic from the executive into the modules, which is good because it should never have been there in the first place. I also added tips to the payment mechanism, which is trivial now.
I removed the historical variants of
UncheckedExtrinsicandMakePayment.This changes the transaction format; for now it is:
The signature payload is:
TODO
Maybe a different PR, maybe not.
subkeyandfactoryto make sure they are always creating txs with correct, decodable and verifiable signatures.Maybe do, maybe don't:
SignedExtension).