This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Change dependencies on hex-literal 0.1 to 0.1.3 to fix build. #3133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Member
|
That was fixed by #3141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
July 16th,
substrate-node-newstopped correctly building new node templates. It failed compiling hex-literal 0.1.4This PR changes all Cargo.toml entries
It leaves dependencies on hex-literal that were already pinned to more specific versions untouched.
This PR is against v1.0 instead of master because there is no build problem on master, and the dependency has already been upgraded to 2.0 in most places on master.
I learned later that
cargo update -p hex-literalmay have obviated removing the Cargo.lock files. Suggestions how to proceed on that front are welcome.