This repository was archived by the owner on Nov 15, 2023. It is now read-only.
consensus: refactor aura and babe proposer #3377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
force-pushed
the
andre/refactor-slot-proposer
branch
from
f6674da to
5a2e948
Compare
andresilva
force-pushed
the
andre/refactor-slot-proposer
branch
from
5a2e948 to
49c3db2
Compare
4 tasks
rphmeier
approved these changes
Aug 14, 2019
Contributor
|
I guess this closes #2689 ? |
Contributor
Author
|
There's still some code duplication in the |
bkchr
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
SimpleSlotWorkertrait which implementson_slotwith the current logic shared between Aura and Babe.