This repository was archived by the owner on Nov 15, 2023. It is now read-only.
session: add handler for genesis session #3413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
previously requested changes
Aug 15, 2019
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Looking good.
But, please make sure that the authorities are always set just once in the genesis. (just retrieve the value from the storage and assert if the value is already set)
andresilva
force-pushed
the
andre/genesis-session
branch
from
ed8a998 to
2333330
Compare
andresilva
force-pushed
the
andre/genesis-session
branch
from
2333330 to
4ef9388
Compare
andresilva
force-pushed
the
andre/genesis-session
branch
from
625c6b4 to
90bd3f2
Compare
andresilva
force-pushed
the
andre/genesis-session
branch
from
3cac2a5 to
f482460
Compare
Contributor
Author
|
Forgot a |
gavofyork
approved these changes
Aug 16, 2019
gavofyork
added
A8-looksgood
and removed
A0-please_review
Member
|
should really be bumping runtime version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SessionHandleris extended with a method for informing about the genesis validator set. This avoids having to configure all of the keys in the chain spec as they will all be initialized from the session module. I still kept the authorities configurable in the modules that interact with session (grandpa, babe, i'm online) because it is useful when using those modules without session.