This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add an RPC method for calling a contract. #3563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A3-in_progress
tomusdrw
reviewed
Sep 10, 2019
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
lgtm! Tiny grumble about RPC call parameters.
tomusdrw
reviewed
Sep 11, 2019
Co-Authored-By: Tomasz Drwięga <[email protected]>
tomusdrw
approved these changes
Sep 12, 2019
andresilva
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Sketch * Some work on docs. * Doc improvements. * More docs. * Some more docs. * Yet another comment. * Bump impl_version. * Accept the block hash * Use NumberOrHex * Update node/rpc/src/contracts.rs Co-Authored-By: Tomasz Drwięga <[email protected]> * Move rpc/primitives
Demi-Marie
pushed a commit
to Demi-Marie/substrate
that referenced
this pull request
Sep 17, 2019
* Sketch * Some work on docs. * Doc improvements. * More docs. * Some more docs. * Yet another comment. * Bump impl_version. * Accept the block hash * Use NumberOrHex * Update node/rpc/src/contracts.rs Co-Authored-By: Tomasz Drwięga <[email protected]> * Move rpc/primitives
en
pushed a commit
to en/substrate
that referenced
this pull request
Sep 24, 2019
* Sketch * Some work on docs. * Doc improvements. * More docs. * Some more docs. * Yet another comment. * Bump impl_version. * Accept the block hash * Use NumberOrHex * Update node/rpc/src/contracts.rs Co-Authored-By: Tomasz Drwięga <[email protected]> * Move rpc/primitives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new custom RPC to node that allows users to call a contract with the current state and receive the output buffer. This is unlike to the executive, where it is not possible to return a result of contract execution.
This feature will help us in writing srml-contracts integration tests, right now we are checking the result of execution by querying the hardcoded storage entries which is not ideal, calling getters would be more convenient.
I believe that the runtime behavior didn't change, hence incrementing only
impl_version.TODO / Follow-ups:
put_code. That would allow to check if a contract is deployable locally.