This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Avoid key collision for child trie #3804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complete some test method by providing child access to values.
is. Need to use historied values, maybe remove pinned, and put some context as parameter for get_offstate
probably need to store state, apply gc on state and depending on result restore state or actually gc historied values.
should get updated.
for gc. Need to change commit set to contain an history of values and adjust test db.
keyspace in the child trie case (need query of kv updates).
are not being cached at this point).
Fix incorrect full storage root.
cheme
added
the
A3-in_progress
cheme
requested review from
gui1117,
jimpo,
kianenigma and
pepyakin
as code owners
Contributor
Author
|
Closing in favor of #4162 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 11/11/19, this PR will revert to initial approach where unique id is provided by the srml storage.