Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
47b4f7c
{core,srml}/authority-discovery: Move generic to specific session keys
mxinden Oct 25, 2019
4d80316
{srml,core}/authority-discovery: Verify signature outside of runtime
mxinden Oct 28, 2019
1be93d3
*: Add authority discovery to the set of session keys
mxinden Oct 28, 2019
3551221
*: Sign authority discovery DHT payload with keystore instead of runtime
mxinden Oct 28, 2019
b516aee
core/authority-discovery: Give libp2p Kademlia time to start up
mxinden Oct 29, 2019
404d9a9
core/authority-discovery: Move authorities priority group name to const
mxinden Oct 29, 2019
e922805
node/runtime/src/lib.rs: Bump runtime spec version
mxinden Oct 29, 2019
38cf886
*: Fix lints and node/testing test failures
mxinden Oct 29, 2019
50e90a9
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Oct 31, 2019
db05799
*: Fix formatting
mxinden Nov 4, 2019
b7b49c4
Merge remote-tracking branch 'master' into refactor-authority-discovery
mxinden Nov 4, 2019
1d72997
Merge branch 'master' of https://github.com/paritytech/substrate into…
mxinden Nov 4, 2019
180f5ec
core/authority-discovery: Box dht event channel in unit tests
mxinden Nov 5, 2019
8aca3d7
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Nov 6, 2019
f8cfff7
node/cli/src/service.rs: Fix future import
mxinden Nov 6, 2019
642ca6c
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Nov 8, 2019
1f5241c
node/cli/src/service.rs: Replace unwrap by expect with proof
mxinden Nov 8, 2019
744c218
node/cli/src/chain_spec: Remove TODO for testnet key generation
mxinden Nov 8, 2019
409d885
core/authority-discovery/src/lib: Remove scale encoding TODOs
mxinden Nov 8, 2019
79de0c0
srml/authority-discovery: Make comment a doc comment
mxinden Nov 10, 2019
0b8f7dd
core/authority-discovery: Remove unused StreamExt import
mxinden Nov 10, 2019
a6d8f6c
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Nov 10, 2019
1a90903
node/runtime: Bump impl version to debug CI
mxinden Nov 10, 2019
a2c9df5
Test ci.
tomusdrw Nov 10, 2019
edff1f8
Change the line width to 100.
tomusdrw Nov 10, 2019
ae5108a
Revert "Change the line width to 100."
tomusdrw Nov 10, 2019
3b71b57
Fix a check for polkadot to work on forked repos.
tomusdrw Nov 10, 2019
65756f9
Revert "node/runtime: Bump impl version to debug CI"
mxinden Nov 10, 2019
0ae3bfe
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Nov 11, 2019
fc5156c
Revert "Test ci."
mxinden Nov 11, 2019
4d36114
Merge remote-tracking branch 'paritytech/master' into refactor-author…
mxinden Nov 12, 2019
56d630c
Cargo.lock: Fix wrong lock file merge
mxinden Nov 12, 2019
b689a1f
srml/authority-discovery: Keep track of new validator set not upcoming
mxinden Nov 14, 2019
89f5018
core/authority-discovery: Document key retrieval functions
mxinden Nov 14, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
core/authority-discovery/src/lib: Remove scale encoding TODOs
  • Loading branch information
mxinden committed Nov 8, 2019
commit 409d88589dce8c57fcb35a889bc31af1addfe825
5 changes: 0 additions & 5 deletions core/authority-discovery/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ where
let mut signed_addresses = vec![];
schema::SignedAuthorityAddresses {
addresses: serialized_addresses.clone(),
// TODO: Instead of encoding via scale and then encoding via proto, we could also convert the signature
// to a [u8] and protobuf encode from there. Important to keep in mind that this module is not anywhere
// close to a resource hot path.
signature: signature.encode(),
}
.encode(&mut signed_addresses)
Expand Down Expand Up @@ -270,8 +267,6 @@ where
signature,
addresses,
} = schema::SignedAuthorityAddresses::decode(value).map_err(Error::DecodingProto)?;
// TODO: Should we rather have a `TryFrom<&[u8]> for Signature` instead of encoding a scale encoded
// signature as Protobuf?
let signature = AuthoritySignature::decode(&mut &signature[..]).map_err(Error::EncodingDecodingScale)?;

if !AuthorityPair::verify(&signature, &addresses, authority_id) {
Expand Down