Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add documentation to SubmitSignedTransaction and actually make it work #4200

Merged
gavofyork merged 37 commits into from
Jan 10, 2020
Merged

Add documentation to SubmitSignedTransaction and actually make it work #4200

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
bc28c60
Add documentation to signed transactions and actually make them work.
tomusdrw Nov 25, 2019
a645b90
Fix naming and bounds.
tomusdrw Nov 25, 2019
f8c9540
Forgotten import.
tomusdrw Nov 25, 2019
f85b890
Merge branch 'master' into td-signed-transactions
tomusdrw Dec 2, 2019
3f38218
Merge branch 'master' into td-signed-transactions
tomusdrw Dec 3, 2019
d715f64
Remove warning.
tomusdrw Dec 3, 2019
0c4c037
Make accounts optional, fix logic.
tomusdrw Dec 3, 2019
dc8d71c
Split the method to avoid confusing type error message.
tomusdrw Dec 3, 2019
173cf6c
Move executor tests to integration.
tomusdrw Nov 28, 2019
90a00fd
Add submit transactions tests.
tomusdrw Dec 3, 2019
901dbdb
Merge branch 'master' into td-signed-transactions
tomusdrw Dec 10, 2019
d103fa1
Make `submit_transaction` tests compile
HCastano Dec 19, 2019
99c54b7
Remove a file that was accidently committed
HCastano Dec 19, 2019
dbc81dd
Merge branch 'master' into td-signed-transactions
tomusdrw Dec 20, 2019
9eb7a2e
Add can_sign helper function.
tomusdrw Dec 20, 2019
0ccb951
Fix compilation.
tomusdrw Dec 20, 2019
73a936c
Add a key to keystore.
tomusdrw Dec 20, 2019
d776d50
Fix the tests.
tomusdrw Dec 20, 2019
0ac61d7
Remove env_logger.
tomusdrw Dec 20, 2019
8755539
Fix sending multiple transactions.
tomusdrw Dec 20, 2019
fc6b5fe
Remove commented code.
tomusdrw Dec 20, 2019
af1782e
Bring back criterion.
tomusdrw Dec 20, 2019
58673bf
Merge branch 'master' into td-signed-transactions
tomusdrw Dec 23, 2019
bacf48c
Remove stray debug log.
tomusdrw Dec 23, 2019
b3c8726
Merge branch 'master' into td-signed-transactions
gavofyork Jan 3, 2020
da816e2
Apply suggestions from code review
tomusdrw Jan 6, 2020
a2c6d09
Make sure to initialize block correctly.
tomusdrw Jan 8, 2020
af5724c
Initialize block for offchain workers.
tomusdrw Jan 8, 2020
3eda535
Add test for transaction validity.
tomusdrw Jan 8, 2020
765f96f
Merge branch 'master' into td-signed-transactions
tomusdrw Jan 8, 2020
6bafaff
Fix tests.
tomusdrw Jan 8, 2020
021f586
Review suggestions.
tomusdrw Jan 8, 2020
3ac00ff
Remove redundant comment.
tomusdrw Jan 8, 2020
7f38d4c
Make sure to use correct block number of authoring.
tomusdrw Jan 8, 2020
afb99f9
Change the runtime API.
tomusdrw Jan 9, 2020
a945a8c
Support both versions.
tomusdrw Jan 9, 2020
4c66a45
Bump spec version, fix RPC test.
tomusdrw Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review suggestions.
  • Loading branch information
@tomusdrw
tomusdrw committed Jan 8, 2020
commit 021f586af1a4b4b8b763810a100f1a78a8e725a3
3 changes: 1 addition & 2 deletions bin/node/executor/tests/basic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2018-2019 Parity Technologies (UK) Ltd.
// Copyright 2018-2020 Parity Technologies (UK) Ltd.
// This file is part of Substrate.

// Substrate is free software: you can redistribute it and/or modify
Expand Down Expand Up @@ -46,7 +46,6 @@ use node_testing::keyring::*;
mod common;
use self::common::{*, sign};
Copy link
Member

@bkchr bkchr Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use self::common::{*, sign};
use self::common::*;

Copy link
Contributor Author

@tomusdrw tomusdrw Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work as there is a conflict with glob imports (common and keystore), so we need to define sign explicitly.



/// The wasm runtime binary which hasn't undergone the compacting process.
///
/// The idea here is to pass it as the current runtime code to the executor so the executor will
Expand Down