Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 26, 2018

Fixes #376 as a side-effect.

Use the "master" branch of libp2p.
This is in fact not the master branch, but the branch polkadot-2 of my fork, which contains master and all the important open PRs merged.

Do not merge yet, as there are some issues with libp2p/rust-libp2p#355

@tomaka tomaka changed the title Switch to the master branch of libp2p [WIP] Switch to the master branch of libp2p Jul 26, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Jul 26, 2018

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

The build is too long for travis 🤦‍♂️

@arkpar
Copy link
Member

arkpar commented Jul 27, 2018

substrate-network-libp2p takes too long to compile on my machine as well

@gavofyork
Copy link
Member

also on my cloud node.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 27, 2018

Pushed a commit that reduces to "only" three minutes on my machine.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 28, 2018

This PR is now ready. It should fix tons of issues with libp2p, most notably with connections not being dropped properly, and another memory leak.

Once #370 is done, I think the network will be robust.

@tomaka tomaka added A0-please_review Pull request needs code review. and removed A1-onice labels Jul 28, 2018
@tomaka tomaka changed the title [WIP] Switch to the master branch of libp2p Switch to the master branch of libp2p Jul 28, 2018
@gavofyork gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jul 28, 2018
@gavofyork gavofyork merged commit fa10e3f into paritytech:master Jul 28, 2018
@tomaka tomaka deleted the libp2p-master branch July 28, 2018 09:54
dvdplm added a commit that referenced this pull request Jul 30, 2018
* master: (86 commits)
  Make contract a separate runtime module (#345)
  Version bump (#450)
  DB-based blockchain data cache for light nodes (#251)
  Update libp2p again (#445)
  Update version on git head change (#444)
  Fix the public key of bootnode 3 (#441)
  Update libp2p (#442)
  Switch to the master branch of libp2p (#427)
  Export ws port 9944 and add doc (#440)
  Iterate over overlay to decide which keys to purge (#436)
  Exit signal gets its own trait (#433)
  Add docker image (#375)
  Reset peers.json if the content is not loadable (#405)
  Limit number of incoming connections (#391)
  Fix memory leaks in libp2p (#432)
  Do not queue empty blocks set for import (#431)
  5 random fixes (#1) (#435)
  Chore: fix typo (#434)
  Prevent building invalid blocks (#430)
  Better logging for public key mismatch (#429)
  ...
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Enable Spot and Bitcoin

* Bump spec version

* Simplify the code of paying no fee a bit

* Nit
liuchengxu added a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
…ion-receipt

Apply the execution receipt which is ready on primary chain
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants