Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@svyatonik
Copy link
Contributor

Functions were removed in #4162 => current client is unable to sync Flaming Fir (but we can reset this chain) and at some point (when commit is picked into polkadot-master) will be unable to sync Kusama (we do not want to reset this chain, right?).

@svyatonik svyatonik added A0-please_review Pull request needs code review. M4-core labels Dec 16, 2019
@svyatonik svyatonik requested a review from pepyakin as a code owner December 16, 2019 12:15
@svyatonik
Copy link
Contributor Author

For reference, if you'll try to sync FF now (with empty db), you'll get:

2019-12-16 14:27:52 Substrate Node
2019-12-16 14:27:52   version 2.0.0-13b1308-x86_64-linux-gnu
2019-12-16 14:27:52   by Parity Technologies, 2017-2019
2019-12-16 14:27:52 Chain specification: Flaming Fir
2019-12-16 14:27:52 Node name: mountainous-fire-8140
2019-12-16 14:27:52 Roles: FULL
2019-12-16 14:27:53 Initializing Genesis block/state (state: 0xd733…e696, header-hash: 0xb653…1d25)
2019-12-16 14:27:53 Loading GRANDPA authority set from genesis on what appears to be first startup.
2019-12-16 14:27:54 cannot create a runtime: Instantiation("Instantiation: Export ext_get_allocated_child_storage not found")
Error: Service(Client(Execution(InvalidCode("Instantiation(\"Instantiation: Export ext_get_allocated_child_storage not found\")"))))

Copy link
Contributor

@expenses expenses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the in-browser light client for me! :D

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions are not used in Kusama anymore, so it is fine to delete them. And I would not like to bring them back. FF is dead anyway.

@ddorgan is currently setting up a new one. (A new test net)

@svyatonik svyatonik closed this Dec 16, 2019
@bkchr bkchr deleted the child_tries_compat_with_old_runtimes branch December 16, 2019 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants