Remove references to frame_consensus from docs #4582
Conversation
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
| //! | ||
| //! ## Related Modules | ||
| //! | ||
| //! - [Consensus](../frame_consensus/index.html) |
There was a problem hiding this comment.
There are more occurrences in this module. However, the whole description of the module in the docs is not correct anymore.
There was a problem hiding this comment.
(maybe not the whole, but crucial parts)
|
I've pushed another commit that attempts a more thorough re-write of the docs for the Session pallet. This writeup is based on my understanding from reading the code and the Seminar about interfacing with Session While the big-picture ideas are correct, I'm not confident that every detail I've written is correct and would appreciate a thorough review and perhaps mentoring if I missed the target. It seems the docs went stale with #2802 |
Co-Authored-By: thiolliere <[email protected]>
…bstrate into joshy-kill-frame-consensus
kianenigma
added
A7-looksgoodtestsfail
and removed
A0-please_review
|
@JoshOrndorff tests are failing. |
JoshOrndorff
added
A0-please_review
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
Except the that OnSessionEnding has changed to SessionManager::new_session. Otherwise lgtm
Co-Authored-By: thiolliere <[email protected]>
Fixes #4574 by removing references to the no-longer-existant
frame_consensus.Should anything more be done here? The docs for Aura used to say: