Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@kianenigma
Copy link
Contributor

same issue as: https://github.com/paritytech/substrate/pull/4429/files

  • Tests already existed; yet they also worked with the wrong binary search since the container to search was just one element. I reviewed all leftover of the binary_seach_xxx in that file and they only apply to members and candidates who are actually sorted by account id; This should close this whole issue.
  • With or without this update, in the next Kusama term change the candidate list should be cleaned. Luckily the phragmen implementation also ignores (kinda by luck; needs issue to be cleaned) dupe candidates so we should be fine.

@kianenigma kianenigma added the A0-please_review Pull request needs code review. label Jan 10, 2020
@kianenigma kianenigma requested a review from gavofyork January 10, 2020 13:28
@kianenigma kianenigma changed the title Fix runner candidacy submission check in council Fix runners-up candidacy submission check in council Jan 10, 2020
@gavofyork gavofyork merged commit dc4216a into master Jan 10, 2020
@gavofyork gavofyork deleted the kiz-phragmen-council-double-vote branch January 10, 2020 14:26
@shawntabrizi
Copy link
Member

This has a broken test @kianenigma @gavofyork

@kianenigma
Copy link
Contributor Author

should be fixed with #4594

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants