This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add trivial EnsureFounder verifier to society #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Jan 13, 2020
shawntabrizi
approved these changes
Jan 14, 2020
Member
There was a problem hiding this comment.
You could also consider adding:
ensure!(Self::founder() != Some(m.clone()), Error::<T, I>::Founder);
To the remove_member function, which would make it so that this founder cannot be suspended/removed from society.
Also this adds 1 storage read to the found extrinsic.
EDIT: Also, so I understand, this origin will likely be used for the SuspensionJudgementOrigin, but the FounderOrigin in the trait config will need to be some hard-coded address right?
Would it make sense to update the name then to BootstrapOrigin?
shawntabrizi
added
A8-looksgood
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for sensible usage of the pallet.