This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Do not issue empty remote read request + fix rr-related trace on full node #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Jan 14, 2020
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Looks good to me, I don't know that much about networking though, but disconnecting + reporting seems reasonable too.
tomusdrw
added
A8-looksgood
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two related issues:
RemoteRead&&RemoteReadChildrequests from light node and it turns current UI (at https://polkadot.js.org/apps/#/) does this;trace!()call in network (when we moved to single-key-in-remote-request to multiple-keys-in-single-remote-request) which leads to panic when invalid request is received over network :(