Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

client/finality-grandpa: Reintegrate periodic neighbor packet worker #4631

Merged
mxinden merged 5 commits into from
Jan 17, 2020
Merged

client/finality-grandpa: Reintegrate periodic neighbor packet worker #4631

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
030f26f
client/finality-grandpa: Reintegrate periodic neighbor packet worker
mxinden Jan 13, 2020
799356e
client/finality-grandpa: Implement Unpin on structs instead of bound
mxinden Jan 16, 2020
5ff36e6
client/finality-grandpa/src/communication/periodic: Add doc comment f…
mxinden Jan 16, 2020
a72797b
client/finality-grandpa/src/communication/mod.rs: Fix typo
mxinden Jan 17, 2020
01d8d4e
client/finality-grandpa/src/communication/mod.rs: Fix typo
mxinden Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
client/finality-grandpa/src/communication/mod.rs: Fix typo 
Co-Authored-By: André Silva <[email protected]>
  • Loading branch information
@mxinden @andresilva
mxinden and andresilva authored Jan 17, 2020
commit 01d8d4e83a3f34f016a384fbd662a3cef3b82619
2 changes: 1 addition & 1 deletion client/finality-grandpa/src/communication/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ pub(crate) struct NetworkBridge<B: BlockT, N: Network<B>> {
/// the underlying `GossipEngine`.
neighbor_sender: periodic::NeighborPacketSender<B>,
Copy link
Contributor Author

@mxinden mxinden Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
neighbor_sender: periodic::NeighborPacketSender<B>,
neighbor_packet_sender: periodic::NeighborPacketSender<B>,

Happy to do this change, but rather as a follow up to reduce the noise within this pull request.


/// `NeighborPacketWorker` processing packets send through the `NeighborPacketSender`.
/// `NeighborPacketWorker` processing packets sent through the `NeighborPacketSender`.
//
// NetworkBridge is required to be clonable, thus one needs to be able to clone its children,
// thus one has to wrap neighor_packet_worker with an Arc Mutex.
Expand Down