Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Call enable_all() when building tokio runtime #4690

Merged
bkchr merged 1 commit into from
Jan 20, 2020
Merged

Call enable_all() when building tokio runtime #4690

bkchr merged 1 commit into from
Jan 20, 2020

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Jan 20, 2020 •
edited
Loading

Otherwise using tokio sockets or timers will panic.
Note that this doesn't affect Polkadot or node-template because they do Runtime::new instead of using a RuntimeBuilder.

@tomaka tomaka added the A0-please_review Pull request needs code review. label Jan 20, 2020
@bkchr bkchr merged commit cfbb24c into paritytech:master Jan 20, 2020
@tomaka tomaka deleted the enable-tokio-rt branch January 20, 2020 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaka @stanislav-tkach @bkchr