This repository was archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: reduce allocations when verifying multiple messages #4693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRANDPA messages are localized when encoded, to include the round and set id they refer to. This means that given a message and a signature there's an extra step of intermediary encoding needed to do the verification. This PR re-uses the buffer used for encoding when verifying multiple messages at once (i.e. commits, catch-up requests and justifications).
@arkpar reported that checking of compact commits was showing up on the profiler as performing a lot of allocations.