This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduces author_hasKey and author_hasSessionKeys rpc endpoints
#4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both endpoints can be used to check if a key is present in the keystore. - `hasKey` works on with an individual public key and key type. It checks if a private key for the given combination exists in the keystore. - `hasSessionKeys` works with the full encoded session key blob stored on-chain in `nextKeys`. This requires that the given blob can be decoded by the runtime. It will return `true`, iff all public keys of the session key exist in the storage. Fixes: #4696
NikVolf
reviewed
Jan 23, 2020
NikVolf
reviewed
Jan 23, 2020
Contributor
|
This really can save some time bootstrapping node/network |
Co-Authored-By: Nikolay Volf <[email protected]>
NikVolf
approved these changes
Jan 23, 2020
tomusdrw
reviewed
Jan 24, 2020
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Looks good apart from the seed / pubkey mismatch. Potentially just a documentation issue.
| fn insert_ephemeral_pair<Pair: PairT>(&mut self, pair: &Pair, seed: &str, key_type: KeyTypeId) { | ||
| let key = (key_type, pair.public().to_raw_vec()); | ||
| self.additional.insert(key, pair.to_raw_vec()); | ||
| self.additional.insert(key, seed.into()); |
Contributor
There was a problem hiding this comment.
The docs for additional say it should be raw public key, but here it seems we just put seed in.
Also we can just put bulshit, cause we don't check that the pair is derived from that seed, do we?
Member
Author
There was a problem hiding this comment.
The docs say: (KeyTypeId, Raw public key) -> Key phrase/seed
Key -> Value
(the key is build above in exactly this way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both endpoints can be used to check if a key is present in the keystore.
hasKeyworks on with an individual public key and key type. Itchecks if a private key for the given combination exists in the
keystore.
hasSessionKeysworks with the full encoded session key blob storedon-chain in
nextKeys. This requires that the given blob can be decodedby the runtime. It will return
true, iff all public keys of thesession key exist in the storage.
Fixes: #4696