Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jan 27, 2020

This is the first step to achieve #4610

First we remove default hasher, later when all conflict has been upgraded, we can introduce a new default.

You can review by commit here, first commit is the change of decl_storage macro, second commit is the fix of all decl_storage calls in substrate.

Note that if the hasher is missing the message printed is:

error: Default hasher has been removed, use explicit hasher(blake2_256) instead.
   --> frame/system/src/lib.rs:479:37
    |
479 |         EventTopics get(fn event_topics): map T::Hash => Vec<(T::BlockNumber, EventIndex)>;
    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Companion PR for polkadot paritytech/polkadot#804

@gui1117 gui1117 added the A0-please_review Pull request needs code review. label Jan 27, 2020
@gui1117 gui1117 changed the title Remove defaul hasher Remove default hasher Jan 27, 2020
@gavofyork gavofyork merged commit d2bb42d into master Jan 27, 2020
@gavofyork gavofyork deleted the gui-remove-defaul-hasher branch January 27, 2020 17:23
sorpaas pushed a commit that referenced this pull request Nov 20, 2020
* remove default hasher from decl_storage!

* fix decl_storage declarations
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants