Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@cecton
Copy link
Contributor

@cecton cecton commented Feb 3, 2020

These are a few changes I missed during the refactoring.

  1. Initialization issue and boilerplate

    Most importantly: part of the Configuration initialization was done in sc_cli::init. This means the user can not benefit from this initialization boilerplate if they have multiple Configuration since sc_cli::init can only be called once.

  2. Boilerplate for VersionInfo and Configuration

    I'm also answering to the critic of @bkchr on the initialization using version: https://github.com/paritytech/substrate/pull/4692/files/bea809d4c14a2ede953227ac885e3b3f9771c548#r372047238 This will allow initializing a Configuration and provide the version by default.

  3. Loading the chain_spec explicitly

    In the past it was done automatically but in some cases we want to delay this. I moved the code to Configuration.load_spec() so it can be called later on. chain_spec can also be written directly to the Configuration without using this load_spec helper.

  4. Make parse_address public

    This change is necessary to allow the user to change the default addresses of rpc_http, rpc_ws and grafana_port.

    [edit: I don't need that!]

  5. Fixing issue that prevents the user to override the port

    In the refactoring I introduced a bug by mistake that could potentially prevent the CLI user to override the ports if defaults where provided for these ports (only on cumulus).

  6. Change task_executor from Box to Arc

    This is useful for cumulus where we have 2 nodes with 2 separate Configuration that need to spawn tasks to the same runtime.

  7. Renamed TasksExecutorRequired to TaskExecutor

    For consistency.

This is related to paritytech/cumulus#24

This is the continuation (and hopefully the end of) #4692

Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
@parity-cla-bot
Copy link

It looks like @cecton signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@cecton cecton requested a review from bkchr February 3, 2020 15:33
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
@cecton cecton self-assigned this Feb 4, 2020
@cecton cecton force-pushed the cecton-cli-improvements branch 2 times, most recently from b987f86 to 82ebab0 Compare February 4, 2020 10:33
Forked at: 9195fac
Parent branch: origin/master
@cecton cecton force-pushed the cecton-cli-improvements branch from e7a7aa9 to c447ef0 Compare February 4, 2020 13:23
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
@cecton cecton force-pushed the cecton-cli-improvements branch from 304e6a7 to 725cf06 Compare February 5, 2020 14:25
@cecton cecton requested a review from tomaka February 5, 2020 15:13
@cecton cecton force-pushed the cecton-cli-improvements branch 2 times, most recently from e5df461 to eec9c0e Compare February 5, 2020 21:32
cecton and others added 2 commits February 6, 2020 09:04
Co-Authored-By: Bastian Köcher <[email protected]>
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
Forked at: 9195fac
Parent branch: origin/master
@cecton cecton merged commit 099cd0f into master Feb 6, 2020
@cecton cecton deleted the cecton-cli-improvements branch February 6, 2020 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants