Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Do not allow zero Existential Deposit when using Balances #4894

Merged
gavofyork merged 14 commits into from
Feb 12, 2020
Merged

Do not allow zero Existential Deposit when using Balances #4894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a8a4129
Add non-zero ed check on Balances genesis
shawntabrizi Feb 11, 2020
af03cd5
Update ED from 0 to 1
shawntabrizi Feb 11, 2020
8b0bc93
bump impl
shawntabrizi Feb 11, 2020
9f377da
bump spec
shawntabrizi Feb 11, 2020
ed584d5
Found remove more ed = 0
shawntabrizi Feb 11, 2020
c6c55bb
Fix some contract tests
shawntabrizi Feb 11, 2020
eb2d9f8
Use ctx.overlay.set_balance for contracts
shawntabrizi Feb 11, 2020
2b3917c
Fix staking test
shawntabrizi Feb 11, 2020
2194fb4
Remove obsolete logic
shawntabrizi Feb 11, 2020
b066018
Allow death of payout account in society
shawntabrizi Feb 11, 2020
decc9a5
Update frame/balances/src/lib.rs
shawntabrizi Feb 11, 2020
0dda80e
Dont create genesis balances if balance is zero in transaction paymen…
shawntabrizi Feb 11, 2020
b0e8432
Merge branch 'shawntabrizi-nonzero-ed' of https://github.com/shawntab…
shawntabrizi Feb 11, 2020
5ff5324
Merge branch 'master' into shawntabrizi-nonzero-ed
gavofyork Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ED from 0 to 1
  • Loading branch information
@shawntabrizi
shawntabrizi committed Feb 11, 2020
commit af03cd5bfcf225c1a11536421cd00de366ca7a66
2 changes: 1 addition & 1 deletion frame/democracy/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down
2 changes: 1 addition & 1 deletion frame/elections/src/mock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl frame_system::Trait for Test {
}

parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down
2 changes: 1 addition & 1 deletion frame/example/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down
2 changes: 1 addition & 1 deletion frame/executive/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Runtime {
Expand Down
2 changes: 1 addition & 1 deletion frame/identity/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down
2 changes: 1 addition & 1 deletion frame/nicks/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down
2 changes: 1 addition & 1 deletion frame/scored-pool/src/mock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ parameter_types! {
pub const MaximumBlockLength: u32 = 2 * 1024;
pub const AvailableBlockRatio: Perbill = Perbill::one();

pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
ord_parameter_types! {
Expand Down
2 changes: 1 addition & 1 deletion frame/society/src/mock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ parameter_types! {
pub const MaximumBlockLength: u32 = 2 * 1024;
pub const AvailableBlockRatio: Perbill = Perbill::one();

pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}

Expand Down
2 changes: 1 addition & 1 deletion frame/transaction-payment/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ mod tests {

parameter_types! {
pub const CreationFee: u64 = 0;
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
}

impl pallet_balances::Trait for Runtime {
Expand Down
2 changes: 1 addition & 1 deletion frame/utility/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ mod tests {
type ModuleToIndex = ();
}
parameter_types! {
pub const ExistentialDeposit: u64 = 0;
pub const ExistentialDeposit: u64 = 1;
pub const CreationFee: u64 = 0;
}
impl pallet_balances::Trait for Test {
Expand Down