This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Hide benchmarks behind a feature flag #5024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
added
the
A3-in_progress
bkchr
reviewed
Feb 25, 2020
Merged
stanislav-tkach
changed the title
stanislav-tkach
added
A0-please_review
marcio-diaz
reviewed
Feb 28, 2020
…aritytech/substrate into stas-benchmarking-feature-4873
shawntabrizi
approved these changes
Mar 1, 2020
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
LGTM but should have a second approval by someone who understands rust features better.
bkchr
approved these changes
Mar 1, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Looks good, but we need to put this on-ice. We first need support for this in wasm-builder. I try to do this today. Otherwise the feature will not be enabled in wasm.
bkchr
added
A1-onice
B0-silent
expenses
suggested changes
Mar 2, 2020
expenses
approved these changes
Mar 2, 2020
Contributor
expenses
left a comment
expenses
left a comment
There was a problem hiding this comment.
Can't comment on the proc macro changes, but the rest looks good to me.
Member
|
Sorry for the delay: #5131 |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
* Hide benchmarks behind a feature flag * Propage attributes in impl_runtime_apis macro * Bump impl_version * Fillter cfg attributes * Hide more things under the feature * Fix set_block_number availability * Rename filter_attrs -> filter_cfg_attrs * Rename runtime_benchmarks to runtime-benchmarks
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* Hide benchmarks behind a feature flag * Propage attributes in impl_runtime_apis macro * Bump impl_version * Fillter cfg attributes * Hide more things under the feature * Fix set_block_number availability * Rename filter_attrs -> filter_cfg_attrs * Rename runtime_benchmarks to runtime-benchmarks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4873.