This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Some networking cleanups #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
commented
Aug 7, 2018
| } | ||
| match swarm_controller.listen_on(shared.config.listen_address.clone()) { | ||
| Ok(new_addr) => { | ||
| debug!(target: "sub-libp2p", "Libp2p listening on {}", new_addr); |
Contributor
Author
There was a problem hiding this comment.
Note that we print new_addr instead of listen_address.
The only practical difference is that if the user specifies port 0, then new_addr will contain the actual port we're listening on, and not 0.
Contributor
There was a problem hiding this comment.
what would happen if there is something already listening on the specified multiaddr?
gavofyork
approved these changes
Aug 7, 2018
gavofyork
approved these changes
Aug 7, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
pepyakin
reviewed
Aug 7, 2018
| } | ||
|
|
||
| /// Create new default configuration for localhost-only connection with random port (usefull for testing) | ||
| /// Create new default configuration for localhost-only connection with random port (useful for testing) |
Contributor
There was a problem hiding this comment.
hm, help me understand, I thought that AddrComponent::TCP(30333) should assign the specific port. Why this saying "with random port" then?
Member
|
Filter functionality is quite useful in parity-ethereum. Is there anything to replace it in libp2p? |
arkpar
approved these changes
Aug 8, 2018
Contributor
Author
I removed it in this PR as it was neither implemented nor used, but it shouldn't be hard to actually implement. |
dvdplm
added a commit
that referenced
this pull request
Aug 9, 2018
* master: README: fixed typo in docker run command (#518) Merge *_at methods. (#515) New flags to listen to all interfaces (#495) If contract reaches max depth, return Err (#503) Some networking cleanups (#504) Derivable Encode & Decode (#509) substrate: return Option in all storage related RPC methods (#510) Build with locked Cargo.lock on CI (#514) Place call data into a newly allocated pages (#502)
gavofyork
pushed a commit
that referenced
this pull request
Aug 10, 2018
* Some networking cleanups * Fix tests * Fix wrong port in new_local
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Update cargo files * First round of build fixes * update lock file
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
This reverts commit 89ac39f.
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…age-access Control non-root storage access
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Signed-off-by: Gregory Hill <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkConfiguration. I removed the fields that were neither set by the CLI nor implemented by libp2p. Re-adding some fields (such asmax_handshakes) can easily be done at the time we implement them.listen_addressandpublic_addressare now aMultiaddrinstead of aSocketAddr. This doesn't change much in practice for now.IpFilterandNetworkIoMessagetypes and the dependency on theipnetworkcrate.