Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Sync: validate block responses for required data #5052

Merged
gnunicorn merged 6 commits into from
Feb 25, 2020
Merged

Sync: validate block responses for required data #5052

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec5f4da
Less verbose state-db logging
arkpar Feb 25, 2020
07e948a
Validate block responses for block bodies
arkpar Feb 25, 2020
565b04b
Update client/network/src/protocol.rs
arkpar Feb 25, 2020
29d475a
Added validation test
arkpar Feb 25, 2020
9198ed6
Disconnect on missing header as well
arkpar Feb 25, 2020
cc3e7e9
Typo
arkpar Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disconnect on missing header as well
  • Loading branch information
@arkpar
arkpar committed Feb 25, 2020
commit 9198ed641130a62bdf52c97ee89fdc726c3665e5
1 change: 1 addition & 0 deletions client/network/src/protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,7 @@ impl<B: BlockT, H: ExHashT> Protocol<B, H> {
} else {
// Validate fields against the request.
if request.fields.contains(message::BlockAttributes::HEADER) && response.blocks.iter().any(|b| b.header.is_none()) {
self.behaviour.disconnect_peer(&peer);
self.peerset_handle.report_peer(peer, rep::BAD_RESPONSE);
trace!(target: "sync", "Missing header for a block");
return CustomMessageOutcome::None
Expand Down