This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Prevent events from being emitted during genesis construction #5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
A0-please_review
bkchr
approved these changes
Mar 30, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Please add a test to ensure this.
Co-Authored-By: Bastian Köcher <[email protected]>
Co-Authored-By: Bastian Köcher <[email protected]>
…om/paritytech/substrate into shawntabrizi-remove-genesis-events
Member
|
Tests still failing |
shawntabrizi
removed
the
A2-insubstantial
bkchr
reviewed
Mar 31, 2020
xlc
reviewed
Mar 31, 2020
NikVolf
approved these changes
Mar 31, 2020
Member
Author
|
IDK why polkadot CI fails, the companion PR is def there. :) |
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
Member
|
You need to mention the companion pr in this pr description. Look at other prs for an example. |
Member
|
Please merge again master^^ |
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…aritytech#948) * Use `add_benchmark` macro * Return error if `batches` is empty * Update Cargo.lock * Companion for paritytech#5463 (paritytech#953) * Fix test with genesis block 0 * Update Cargo.lock
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops System events from being populated during genesis construction.
The significant change here is that the
Numberstorage item is set to 0 now at genesis rather than 1.polkadot companion: paritytech/polkadot#953