This repository was archived by the owner on Nov 15, 2023. It is now read-only.
support: add lateness trait #5519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
andresilva
requested review from
Demi-Marie,
gui1117 and
kianenigma
as code owners
gavofyork
reviewed
Apr 3, 2020
| let lateness = current_slot.saturating_sub(CurrentSlot::get() + 1); | ||
| let lateness = T::BlockNumber::from(lateness as u32); | ||
|
|
||
| Lateness::<T>::put(lateness); |
Member
There was a problem hiding this comment.
We're trying to cut down on extra DB I/O as it's pretty slow. Could we get this merged into CurrentSlot?
Contributor
Author
There was a problem hiding this comment.
This is always killed in on_finalize and should never reach the DB. Added some comments on this.
bkchr
reviewed
Apr 3, 2020
Member
|
You need to merge master to make the polkadot build green :) |
rphmeier
approved these changes
Apr 3, 2020
bkchr
approved these changes
Apr 4, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trait for reporting how late the current block is and implement it for BABE.