This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove sp-runtime dependency from sp-phragmen #5786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
suggested changes
Apr 26, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
You need to replace RuntimeDebug by custom Debug impls.
primitives/phragmen/Cargo.toml
Outdated
| sp-runtime = { version = "2.0.0-dev", default-features = false, path = "../../primitives/runtime" } | ||
| sp-phragmen-compact = { version = "2.0.0-dev", path = "./compact" } | ||
| sp-arithmetic = { version = "2.0.0-dev", default-features = false, path = "../arithmetic" } | ||
| sp-core = { version = "2.0.0-dev", default-features = false, path = "../core" } |
Member
There was a problem hiding this comment.
Replacing sp-runtime with sp-core does not solve the issue.
Contributor
There was a problem hiding this comment.
yeah indeed, goal is to move this out of substrate and not depend on these beefy crates like sp-runtime and sp-core. Only arithmetic is really needed. but it may not be as trivial as I formulated in the issue:
1- custom Debug impls will be needed
2- Some trait bounds (like Member) could be removed if needed.
Member
There was a problem hiding this comment.
- Is really easy.
RuntimeDebugjust prints<wasm:stripped>when callingDebugand this can easily be done with some manual impls. Or we even just use the normalDebugderive. - Is solved.
Contributor
Author
There was a problem hiding this comment.
Can we move sp-debug-derive outside of substrate too and still use it in order to reduce manual Debug implementations?
kianenigma
added
A5-grumble
and removed
A0-please_review
bkchr
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5542.