Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Refactor weight constants, Update to remove redundant overhead #5884

Merged
gavofyork merged 8 commits into from
May 4, 2020
Merged

Refactor weight constants, Update to remove redundant overhead #5884

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7c058d
Move weight values to `frame_support`
shawntabrizi May 4, 2020
d334124
more accurate comment
shawntabrizi May 4, 2020
f79ee98
update balances
shawntabrizi May 4, 2020
501b574
vesting
shawntabrizi May 4, 2020
b74fd62
update util
shawntabrizi May 4, 2020
936710b
Add weight to time constants
shawntabrizi May 4, 2020
bb736be
use weight constants in weights
shawntabrizi May 4, 2020
30bbe3d
update tests
shawntabrizi May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vesting
  • Loading branch information
@shawntabrizi
shawntabrizi committed May 4, 2020
commit 501b574648a0e7183638e48a0d6f76cd84ae64d7
22 changes: 11 additions & 11 deletions frame/vesting/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,11 @@ decl_module! {
/// - Reads: Vesting Storage, Balances Locks, [Sender Account]
/// - Writes: Vesting Storage, Balances Locks, [Sender Account]
/// - Benchmark:
/// - Unlocked: 56.1 + .098 * l µs (min square analysis)
/// - Locked: 54.37 + .254 * l µs (min square analysis)
/// - Using 60 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// - Unlocked: 48.76 + .048 * l µs (min square analysis)
/// - Locked: 44.43 + .284 * l µs (min square analysis)
/// - Using 50 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// # </weight>
#[weight = 60_000_000 + T::DbWeight::get().reads_writes(2, 2)]
#[weight = 50_000_000 + T::DbWeight::get().reads_writes(2, 2)]
fn vest(origin) -> DispatchResult {
let who = ensure_signed(origin)?;
Self::update_lock(who)
Expand All @@ -219,11 +219,11 @@ decl_module! {
/// - Reads: Vesting Storage, Balances Locks, Target Account
/// - Writes: Vesting Storage, Balances Locks, Target Account
/// - Benchmark:
/// - Unlocked: 58.09 + .104 * l µs (min square analysis)
/// - Locked: 55.35 + .255 * l µs (min square analysis)
/// - Using 60 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// - Unlocked: 44.3 + .294 * l µs (min square analysis)
/// - Locked: 48.16 + .103 * l µs (min square analysis)
/// - Using 50 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// # </weight>
#[weight = 60_000_000 + T::DbWeight::get().reads_writes(3, 3)]
#[weight = 50_000_000 + T::DbWeight::get().reads_writes(3, 3)]
fn vest_other(origin, target: <T::Lookup as StaticLookup>::Source) -> DispatchResult {
ensure_signed(origin)?;
Self::update_lock(T::Lookup::lookup(target)?)
Expand All @@ -244,10 +244,10 @@ decl_module! {
/// - DbWeight: 3 Reads, 3 Writes
/// - Reads: Vesting Storage, Balances Locks, Target Account, [Sender Account]
/// - Writes: Vesting Storage, Balances Locks, Target Account, [Sender Account]
/// - Benchmark: 111.4 + .345 * l µs (min square analysis)
/// - Using 115 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// - Benchmark: 100.3 + .365 * l µs (min square analysis)
/// - Using 100 µs fixed. Assuming less than 50 locks on any user, else we may want factor in number of locks.
/// # </weight>
#[weight = 115_000_000 + T::DbWeight::get().reads_writes(3, 3)]
#[weight = 100_000_000 + T::DbWeight::get().reads_writes(3, 3)]
pub fn vested_transfer(
origin,
target: <T::Lookup as StaticLookup>::Source,
Expand Down