Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

grandpa: minor cleanups in communication module #6371

Merged
andresilva merged 6 commits into from
Jun 30, 2020
Merged

grandpa: minor cleanups in communication module #6371

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9e62ce
grandpa: replace Result<(), ()> with Option<()>
andresilva Jun 16, 2020
6fb5f65
grandpa: replace &Option<T> with Option<&T>
andresilva Jun 16, 2020
5335282
grandpa: cleanup local id and keystore usages
andresilva Jun 16, 2020
53fb446
grandpa: return bool on check_message_signature
andresilva Jun 16, 2020
5419e14
grandpa: fix erroneous log message on startup
andresilva Jun 16, 2020
cf0010e
grandpa: fix test
andresilva Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
grandpa: fix test
  • Loading branch information
@andresilva
andresilva committed Jun 16, 2020
commit cf0010e5a7212fef9262c6ae9ca78f2b22f39dc5
4 changes: 2 additions & 2 deletions client/finality-grandpa/src/communication/gossip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2624,12 +2624,12 @@ mod tests {
fn allow_noting_different_authorities_for_same_set() {
let (val, _) = GossipValidator::<Block>::new(config(), voter_set_state(), None);

let a1 = vec![AuthorityId::default()];
let a1 = vec![AuthorityId::from_slice(&[0; 32])];
val.note_set(SetId(1), a1.clone(), |_, _| {});

assert_eq!(val.inner().read().authorities, a1);

let a2 = vec![AuthorityId::default(), AuthorityId::default()];
let a2 = vec![AuthorityId::from_slice(&[1; 32]), AuthorityId::from_slice(&[2; 32])];
val.note_set(SetId(1), a2.clone(), |_, _| {});

assert_eq!(val.inner().read().authorities, a2);
Expand Down