Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add log rotation #6564

Merged
12 commits merged into from
Jul 8, 2020
Merged

Add log rotation #6564

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2e922b
Use flexi_logger; Add log rotation
Jul 3, 2020
d5f0046
Add default rotation; Add FlexiLogger error
Jul 3, 2020
50abd62
Fix compilation error
Jul 3, 2020
b96dad4
Remove logging to stdout if it's not a tty
Jul 3, 2020
896d291
Merge branch 'master' of github.com:paritytech/substrate into scott_l…
Jul 3, 2020
7a5b29b
Fix formatting
pscott Jul 6, 2020
91e0056
Merge branch 'scott_log_rotation' of github.com:paritytech/substrate …
Jul 6, 2020
57cca14
Remove needless debug statement
Jul 6, 2020
c4fae35
Default to unlimited size for log rotation
Jul 6, 2020
5417943
Add more comments about log-age option
Jul 6, 2020
baec590
Remove unused variable
Jul 6, 2020
e5f2b22
Fix typo in comment
Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more comments about log-age option
  • Loading branch information
Scott Piriou committed Jul 6, 2020
commit 5417943b26ee38273e05efe4d7f19d47fa6a5a26
3 changes: 2 additions & 1 deletion client/cli/src/logger.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ pub struct LogRotationOpt {
#[structopt(long, parse(from_os_str))]
log_directory: Option<PathBuf>,

/// Rotate the log file when it has become older than the specified age.
/// Rotate the log file when the local clock has started a new day/hour/minute/second
/// since the current file has been created.
#[structopt(long,
conflicts_with("log-size"),
possible_values(&["day", "hour", "minute", "second"]),
Copy link
Contributor

@tomaka tomaka Jul 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you'd for example pass --log-age minute? I don't understand this.

Copy link
Contributor Author

@pscott pscott Jul 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's inspired by the Age enum from flexi_logger :) I could remove minute / second or even rename them if you think we could use a better name ! :)

Copy link
Contributor

@tomaka tomaka Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of the Age enum that you linked does make sense because it explains what the values mean.

Copy link
Contributor Author

@pscott pscott Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5417943 :)

Expand Down