Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix treasury minting #707

Merged
gavofyork merged 6 commits into from
Sep 11, 2018
Merged

Fix treasury minting #707

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cccb16
Fix minting to do what it's meant to.
gavofyork Sep 10, 2018
fc9b89d
Merge remote-tracking branch 'origin/master' into gav-fix-minting
gavofyork Sep 10, 2018
2cb1e45
Fix tests
gavofyork Sep 10, 2018
bf5ad98
Note and fix total issuance.
gavofyork Sep 10, 2018
a52d839
Undo last non-fix.
gavofyork Sep 10, 2018
cb42d70
More doc
gavofyork Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More doc
  • Loading branch information
@gavofyork
gavofyork committed Sep 10, 2018
commit cb42d7032ff0b37d17c65d4aac2b9b9075628191
3 changes: 2 additions & 1 deletion substrate/runtime/balances/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ impl<

/// Trait for a hook to get called when some balance has been minted, causing dilution.
pub trait OnDilution<Balance> {
/// Some `portion` of the total balance "grew" by `minted`.
/// Some `portion` of the total balance just "grew" by `minted`. `portion` is the pre-growth
/// amount (it doesn't take account of the recent growth).
fn on_dilution(minted: Balance, portion: Balance);
Copy link
Contributor

@rphmeier rphmeier Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the portion before or after having balance minted to it?

Copy link
Contributor

@rphmeier rphmeier Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(documentation should answer this question)

}

Expand Down