Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
250fbeb
babe: backoff authoring blocks when finality lags
octol Sep 16, 2020
d531efa
babe: move backoff authoring params to default constructor
octol Sep 22, 2020
b060e9b
babe: deduplicate the test a bit
octol Sep 22, 2020
0f95c44
babe: set backoff constants in service
octol Sep 23, 2020
df1951c
babe: use better names for backoff authoring block parameters
octol Sep 23, 2020
c17ca03
babe: remove last unwrap
octol Sep 23, 2020
2892da0
babe: slight style tweak
octol Sep 23, 2020
01f1ac3
babe: fix comment
octol Sep 23, 2020
9794ffa
slots: move backoff block authorship logic to SimpleSlotWorker
octol Sep 28, 2020
d2ee780
aura: append SlotInfo in on_slot
octol Sep 30, 2020
026a8d0
slots: use the correct types for parameters
octol Sep 30, 2020
f428a35
Merge branch 'master' into jon/incremental-backoff-on-finality
octol Oct 14, 2020
6903837
slots: fix review comments
octol Oct 23, 2020
4a6b8b7
Merge branch 'master' into jon/incremental-backoff-on-finality
octol Oct 23, 2020
92b506a
aura: add missing backoff authoring blocks parameters
octol Oct 23, 2020
cda5150
slots: add comments for default values
octol Oct 27, 2020
62f97dc
slots: add additional checks in test
octol Oct 27, 2020
7fa2084
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Oct 28, 2020
af8d30b
slots: update implementation for new master
octol Oct 28, 2020
76b745a
slots: revert the change to SlotInfo
octol Oct 28, 2020
dafd2e5
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Oct 28, 2020
dc04a1f
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Oct 29, 2020
cb6d24c
Fix review comments
octol Oct 30, 2020
55827c3
slots: rework unit tests for backing off claiming slots
octol Nov 2, 2020
83538f0
slots: add test for asymptotic behaviour for slot claims
octol Nov 3, 2020
c87145d
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Nov 3, 2020
0435142
slots: address review comments
octol Nov 4, 2020
38e61e5
slots: add test for max_interval
octol Nov 4, 2020
1228aef
slots: add assertion for intervals between between claimed slots
octol Nov 4, 2020
f7b8c76
slots: remove rustfmt directive
octol Nov 4, 2020
9790f60
slots: another attempt at explaining authoring_rate
octol Nov 4, 2020
f95225a
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Nov 4, 2020
461d5f9
slots: up unfinalized_slack to 50 by default
octol Nov 6, 2020
796baf7
slots: add tests for time to reach max_interval
octol Nov 6, 2020
0d11df5
slots: fix typo in comments
octol Nov 6, 2020
9a968c6
Apply suggestions from code review
octol Nov 10, 2020
a607bc4
slots: additional tweaks to comments and info calls
octol Nov 10, 2020
bc32a7c
slots: rename to BackoffAuthoringOnFinalizedHeadLagging
octol Nov 10, 2020
eb45ed7
slots: make the backing off strategy generic
octol Nov 10, 2020
5a40da8
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Nov 10, 2020
4f44b62
Apply suggestions from code review
octol Nov 10, 2020
1423649
slots: implement backoff trait for () for simplicity
octol Nov 10, 2020
44de2cf
slots: move logging inside backing off function to make it more specific
octol Nov 11, 2020
90d0ad3
Merge remote-tracking branch 'upstream/master' into jon/incremental-b…
octol Nov 11, 2020
b6435ff
aura: add missing function parameter
octol Nov 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
slots: up unfinalized_slack to 50 by default
  • Loading branch information
octol committed Nov 6, 2020
commit 461d5f926987c5bfdbb2d2a23cb4f54032b02523
2 changes: 1 addition & 1 deletion client/consensus/slots/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ impl<N: BaseArithmetic> Default for SimpleBackoffAuthoringBlocksStrategy<N> {
max_interval: 100.into(),
// Start to consider backing off block authorship once we have 5 or more unfinalized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Start to consider backing off block authorship once we have 5 or more unfinalized
// Start to consider backing off block authorship once we have 50 or more unfinalized

// blocks at the head of the chain.
unfinalized_slack: 5.into(),
unfinalized_slack: 50.into(),
// A reasonable default for the authoring bias, or reciprocal interval scaling, is 2.
// Effectively meaning that consider the unfinalized head suffix length to grow half as
// fast as in actuality.
Expand Down