This repository was archived by the owner on Nov 15, 2023. It is now read-only.
remove deprecated only/except clauses #7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriplEight
added
A3-in_progress
github-actions
bot
added
A0-please_review
Contributor
Author
|
Notes:
|
gabreal
approved these changes
Sep 30, 2020
Contributor
gabreal
left a comment
gabreal
left a comment
There was a problem hiding this comment.
looks good, but haven't tested.
gabreal
reviewed
Sep 30, 2020
.gitlab-ci.yml
Outdated
| - if: $CI_COMMIT_REF_NAME == "master" | ||
| changes: | ||
| - .gitlab-ci.yml | ||
| - .maintain/monitoring/ |
Contributor
There was a problem hiding this comment.
this would have to be .maintain/monitoring/* actually according to https://docs.gitlab.com/ee/ci/yaml/#onlychangesexceptchanges . i was actually sure it was working before.
Contributor
Author
There was a problem hiding this comment.
fixed with maintain/monitoring/**/* as it has dirs inside
TriplEight
changed the title
liuchengxu
pushed a commit
to liuchengxu/substrate
that referenced
this pull request
Oct 5, 2020
* change (CI): remove deprecated only/except clauses * change (CI): remove * change (CI): debug regex * change (CI): regex shouldn't be surrounded with quotes in `rules` * change (CI): no quotes in `rules` * change (CI): debug workflow * change (CI): almost equal * change (CI): splinters * change (CI): some details [chaos:basic] * change (CI): add manual substrate build on PRs * change (CI): mistake with publish-to-crates-io * change (CI): reapproach chaos-only; rename rules anchors [skip ci] * change (CI): add linux and mac to manual jobs for PRs [skip ci] * change (CI): remove `pre-v` tags rules [skip ci] * change (CI): add subkey for macos build as manual on PRs as well * change (CI): add glob to match every changed file in monitoring * test (CI): [chaos:basic]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot companion: paritytech/polkadot#1769
onlyandacceptkeys to not very readablerules. The upside is withoutonly, DAGs will be accessible.DEPLOY_TAGexample of a pipeline for a regular PR https://gitlab.parity.io/parity/substrate/-/pipelines/109099
example of a pipeline with
[chaos:basic]in commit text https://gitlab.parity.io/parity/substrate/-/pipelines/109101