Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2020

Bumps linregress from 0.1.7 to 0.4.0.

Commits
  • 23bdada New version 0.4.0
  • 60d88bf Implement Clippy suggestions
  • 8f1df08 Switch Error type to enum and remove deprecated display method
  • 0cf1b94 Add newlines between items (functions, structs, etc...)
  • 5eaee35 Reimplement subtract_value_from_matrix and get rid of matrix_as_vec
  • cf2e5be Ensure model is consistent before prediction
  • 0a97d02 Document lack of non real value handling in predict
  • 8de8b8c Document expected input of predict
  • 7efd9a4 Implement new ErrorKinds and ensure vectors are consistent
  • 5cd3ab1 Add more tests (two of these currently failing)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 20, 2020
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 20, 2020
@gui1117
Copy link
Contributor

gui1117 commented Nov 23, 2020

bumping linregress, makes wasm build with runtime-benchmark feature failing.

It seems new version of linregress, bring new version of nalgebra which brings a version of rand_core which brings std.

Actually I don't understand why old linregress version was working in the first place as it doesn't seem to support environment without std either.

If I can understand how linregress wasn't importing std in the old version maybe I can understand why if is doing so now.
Otherwise and I think it is the most future proof we should push to upstream linregress to support no std environment.

@bkchr
Copy link
Member

bkchr commented Nov 23, 2020

Superseded by #7580

@bkchr bkchr closed this Nov 23, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 23, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/linregress-0.4.0 branch November 23, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants