This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add payment_queryFeeDetails RPC #7692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Dec 8, 2020
kianenigma
reviewed
Dec 16, 2020
kianenigma
reviewed
Dec 16, 2020
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Looks overall good, would be good if someone can look closer into the serde details as well.
… add-fee-details-rpc
… add-fee-details-rpc
kianenigma
reviewed
Dec 18, 2020
kianenigma
reviewed
Dec 18, 2020
kianenigma
reviewed
Dec 18, 2020
kianenigma
reviewed
Dec 18, 2020
shawntabrizi
added
the
C1-low
gui1117
reviewed
Jan 4, 2021
Co-authored-by: Guillaume Thiolliere <[email protected]>
gui1117
added
A0-please_review
Contributor
|
at some point I wonder if those two RPC shouldn't be merged, or just the new RPC have all information so that we don't break RPCs. But I'm ok like this. |
kianenigma
added
the
D9-needsaudit 👮
Contributor
|
^^ the refactor that also affects the runtime code is minimal, but still, I think this is the correct next step. Correct me otherwise. |
… add-fee-details-rpc
… add-fee-details-rpc
… add-fee-details-rpc
bkchr
reviewed
Jan 13, 2021
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
We also don't bump the version of the runtime api. As it will only return error when calling the RPC and the runtime api doesn't exist, I'm fine with it.
gui1117
added
D1-audited 👍
… add-fee-details-rpc
bkchr
approved these changes
Jan 14, 2021
Member
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new RPC
payment_queryFeeDetailswhich returns the details of the final fee, there are no changes to the existing payment RPC.Close #7691