Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Allow 24 nominations per validator and publish count #7929

Closed
gavofyork wants to merge 17 commits into from
Closed

Allow 24 nominations per validator and publish count #7929

Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ca69a9b
Allow 24 nominations per validator and publish count
gavofyork Jan 19, 2021
1d2a95f
Fix test.
kianenigma Jan 19, 2021
75d65d3
Fix fuzzers.
kianenigma Jan 19, 2021
0975077
Another fix.
kianenigma Jan 20, 2021
8409407
checkpoint
kianenigma Jan 21, 2021
c5b2836
checkpoint
kianenigma Jan 21, 2021
3730a32
Again, merge master
kianenigma Jan 21, 2021
7d53b07
Tidy it up.
kianenigma Jan 21, 2021
a128b7a
remove cfg
kianenigma Jan 21, 2021
ca0e5ad
Update frame/staking/src/lib.rs
kianenigma Feb 9, 2021
1eccbae
Update frame/staking/src/lib.rs
kianenigma Feb 9, 2021
ec3ad08
Update frame/staking/src/lib.rs
kianenigma Feb 9, 2021
69eb563
Merge branch 'master' of github.com:paritytech/substrate into gav-24-…
kianenigma Feb 10, 2021
45e9c65
Merge branch 'gav-24-nominations' of github.com:paritytech/substrate …
kianenigma Feb 10, 2021
57cdfe5
make the line width happy.
kianenigma Feb 10, 2021
32f2c7f
Line width, again.
kianenigma Feb 10, 2021
0e32536
Merge branch 'master' of github.com:paritytech/substrate into gav-24-…
kianenigma Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frame/staking/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ use sp_npos_elections::{
};
pub use weights::WeightInfo;

/// The default solution type used in substrate-node with 24 maximum winners. A runtime can customize this to their needs.
/// The default solution type used in substrate-node with 24 maximum votes per voter. A runtime can customize this to their needs.
pub mod default_solution {
Copy link
Contributor

@kianenigma kianenigma Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I put this mostly here so that it can be blindly used in tests/benchmarks etc. Polkadot or any other chain should probably generate their own version.

use super::*;
pub use sp_npos_elections::CompactSolution;
Expand Down Expand Up @@ -1402,8 +1402,8 @@ decl_module! {
}

fn integrity_test() {
// Ensure the size of both ValidatorIndex and NominatorIndex. They both need to be well
// below usize.
// Ensure the size of both ValidatorIndex and NominatorIndex. They both need to be less or
// equal to usize.
assert!(size_of::<ValidatorIndexOf<T>>() <= size_of::<usize>());
assert!(size_of::<ValidatorIndexOf<T>>() <= size_of::<u32>());
assert!(size_of::<NominatorIndexOf<T>>() <= size_of::<usize>());
Expand Down Expand Up @@ -2276,7 +2276,7 @@ decl_module! {
}
}

impl<T: Config> Module<T> {
impl<T: Config> Module<T> {
/// The total balance that can be slashed from a stash account as of right now.
pub fn slashable_balance_of(stash: &T::AccountId) -> BalanceOf<T> {
// Weight note: consider making the stake accessible through stash.
Expand Down