This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make pallet use construct_runtime in tests instead of impl_* #7986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
Member
Fuck, finally! I still would like to have official rust support, but better than nothing. |
bkchr
approved these changes
Jan 26, 2021
shawntabrizi
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I make changes for pallets randomness-collective-flip, recovery, scheduler, scored-pool, session, society, staking, sudo, timestamp, tips, transaction-payment, treasury, utility, vesting.
the reason some pallet needs to import serde is because when macro_rules macro are using
$crate::serdeI think it can result is errors somehow.There is an attribute that can be given to serde to resolve this https://serde.rs/container-attrs.html#crate but it is difficult to do this in this macro_rules macro. IMO it should be solved later when those are rewritten in procedural macro.