This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Disable Kademlia random walk when --reserved-nodes is passed #7999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
romanb
approved these changes
Jan 28, 2021
mxinden
approved these changes
Jan 28, 2021
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Looks good to me.
I find the reserved_only flag misleading. Something along the lines of sync_with_reserved_only would be easier for me to grasp. I don't think this should be the concern of this pull request though.
Co-authored-by: Roman Borschel <[email protected]>
Contributor
Author
That would be an annoying breaking change unfortunately, as I imagine that a lot of people use this option, but I guess we could introduce a second CLI option and deprecate the first one. |
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6031
Disables automatically finding new peers when
--reserved-nodesis passed.Note that this behaviour is specific to the CLI. The network itself can still be configured to randomly walk the DHT even in reserved-only mode.