This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix tracing spans are not being forwarded to spawned task #8009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug that tracing spans are not forwarded to spawned task. The problem was that only the telemetry span was forwarded. The solution to this is to use the tracing provided `in_current_span` to capture the current active span and pass the telemetry span explictely. We will now always enter the span when the future is polled. This is essentially the same strategy as tracing is doing with its `Instrumented`, but now extended for our use case with having multiple spans active.
bkchr
added
A0-please_review
dvdplm
approved these changes
Feb 1, 2021
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
Looks sane to my eyes.
Maybe it'd be good to have a test that checks Event emission works as expected too?
| self.executor.spawn(Box::pin(future.in_current_span()), task_type) | ||
| }; | ||
| let future = future.in_current_span().boxed(); | ||
| let join_handle = self.executor.spawn( |
Contributor
There was a problem hiding this comment.
Did you explore instrumenting the executor itself? Not sure if that would work, but if it did maybe it could perhaps save some busywork?
Member
Author
There was a problem hiding this comment.
In the end that is what we are doing here. We instrument the executor :D
The TaskExecutor itself is just a Fn(Future, Type)
Member
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
cecton
pushed a commit
that referenced
this pull request
Feb 4, 2021
* Fix tracing spans are not being forwarded to spawned task There is a bug that tracing spans are not forwarded to spawned task. The problem was that only the telemetry span was forwarded. The solution to this is to use the tracing provided `in_current_span` to capture the current active span and pass the telemetry span explictely. We will now always enter the span when the future is polled. This is essentially the same strategy as tracing is doing with its `Instrumented`, but now extended for our use case with having multiple spans active. * More tests
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2021
* Fix tracing tests (#8022) * Fix tracing tests The tests were not working properly. 1. Some test was setting a global subscriber, this could lead to racy conditions with other tests. 2. A logging test called `process::exit` which is completly wrong. * Update client/tracing/src/lib.rs Co-authored-by: David <[email protected]> * Review comments Co-authored-by: David <[email protected]> * Fix tracing spans are not being forwarded to spawned task (#8009) * Fix tracing spans are not being forwarded to spawned task There is a bug that tracing spans are not forwarded to spawned task. The problem was that only the telemetry span was forwarded. The solution to this is to use the tracing provided `in_current_span` to capture the current active span and pass the telemetry span explictely. We will now always enter the span when the future is polled. This is essentially the same strategy as tracing is doing with its `Instrumented`, but now extended for our use case with having multiple spans active. * More tests * Proper test for telemetry and prefix span * WIP * Fix test (need to create & enter the span at the same time) * WIP * Remove telemtry_span from sc_service config * CLEANUP * Update comment * Incorrect indent * More meaningful name * Dedent * Naming XD * Attempt to make a more complete test * lint * Missing licenses * Remove user data * CLEANUP * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * CLEANUP * Apply suggestion * Update bin/node/cli/tests/telemetry.rs Co-authored-by: David <[email protected]> * Wrapping lines Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: David <[email protected]>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that tracing spans are not forwarded to spawned task. The
problem was that only the telemetry span was forwarded. The solution to
this is to use the tracing provided
in_current_spanto capture thecurrent active span and pass the telemetry span explictely. We will now
always enter the span when the future is polled. This is essentially the
same strategy as tracing is doing with its
Instrumented, but nowextended for our use case with having multiple spans active.