This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Migration testing runtime API/Bot #8038
Merged
25 commits merged into
master
from
kiz-finally-finally-finally-finally-migration-testing-2
Feb 19, 2021
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4c0abc5
A clean new attempt
kianenigma 7f9b5b8
Checkpoint to move remote.
kianenigma 4883812
A lot of dependency wiring to make it feature gated.
kianenigma be549b4
bad macro, bad macro.
kianenigma 8e97733
Master.into()
kianenigma d84dad4
Undo the DB mess.
kianenigma aeb7a0e
Update frame/support/src/traits.rs
kianenigma d968f58
Apply suggestions from code review
kianenigma ce4128b
unbreak the build
kianenigma ee8ae08
Merge branch 'kiz-finally-finally-finally-finally-migration-testing-2…
kianenigma 62be119
Master.into()
kianenigma 712c240
Update frame/try-runtime/src/lib.rs
kianenigma 9a23940
Update utils/frame/try-runtime/cli/Cargo.toml
kianenigma 93f299a
Update frame/try-runtime/Cargo.toml
kianenigma 3cea840
Address most review grumbles.
kianenigma ab9d4a3
Upstream.into()
kianenigma b13ea31
Fix build
kianenigma d3a2368
Add some comments
kianenigma c8ba546
Remove allowing one pallet at a time.
kianenigma 2f9ad0e
More grumbles.
kianenigma 6db195c
Merge branch 'master' of github.com:paritytech/substrate into kiz-fin…
kianenigma b8ab620
relocate remote-ext
kianenigma be5210d
Merge branch 'master' of github.com:paritytech/substrate into kiz-fin…
kianenigma b5e394b
Fix build
kianenigma deb03d4
Merge branch 'master' of github.com:paritytech/substrate into kiz-fin…
kianenigma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix build
- Loading branch information
commit b5e394b45aaa06bc5ece366cac113bad87b52b3e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -153,14 +153,12 @@ pub fn run() -> Result<()> { | |
| Some(Subcommand::TryRuntime(cmd)) => { | ||
| let runner = cli.create_runner(cmd)?; | ||
| runner.async_run(|config| { | ||
| use sc_service::TaskManager; | ||
| // we don't need any of the components of new_partial, just a runtime, or a task | ||
| // manager to do `async_run`. | ||
| let registry = config.prometheus_config.as_ref().map(|cfg| &cfg.registry); | ||
| let task_manager = TaskManager::new( | ||
| let task_manager = sc_service::TaskManager::new( | ||
| config.task_executor.clone(), | ||
| registry, | ||
| config.telemetry_span.clone(), | ||
| ).unwrap(); | ||
kianenigma marked this conversation as resolved.
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. out of curiosity, why async here ? instead of sync like we do for benchmarks ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remote-externalities is working with async/await, my assumption was that in such case you need to use the async_runner 🤔 |
||
|
|
||
| Ok((cmd.run::<Block, Executor>(config), task_manager)) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.