Replace last usages of <() as PalletInfo> in substrate
#8080
Conversation
gui1117
added
A0-please_review
|
|
||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
note: I didn't use construct_runtime here because runtime declare a very specific implementation of Call which is not compatible with the code generated by construct_runtime
|
|
||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
Note: I didn't use construct_runtime here because I don't think it is really needed for the test, and the easiest is a manual implementation.
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Besides the duplicate, it looks good
| pub struct PanicPalletInfo; | ||
|
|
||
| impl frame_support::traits::PalletInfo for PanicPalletInfo{ | ||
| fn index<P: 'static>() -> Option<usize> { | ||
| unimplemented!("PanicPalletInfo mustn't be triggered by tests"); | ||
| } | ||
| fn name<P: 'static>() -> Option<&'static str> { | ||
| unimplemented!("PanicPalletInfo mustn't be triggered by tests"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why don't you use it from frame-support?
There was a problem hiding this comment.
in frame-support I didn't expose it, it is hidden behind the #[cfg(test)] flag, but we could make it public.
There was a problem hiding this comment.
Ahh I had overseen this. Maybe move it at least from the traits file then?
There was a problem hiding this comment.
yes, I moved it to tests module
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 4 participants
related #7949