refactor(remote ext): use jsonrpsee #8105
Conversation
…tech/substrate into na-remote-ext-jsonrpsee-show-kian
…lly-migration-testing-2' into na-remote-ext-jsonrpsee-show-kian
…lly-migration-testing-2' into na-remote-ext-jsonrpsee-show-kian
Co-authored-by: Kian Paimani <[email protected]>
…tech/substrate into na-remote-ext-jsonrpsee-show-kian
|
Waht's the prospect of this? |
After paritytech/jsonrpsee#215 is merged, I plan to publish an alpha release for the clients |
niklasad1
added
the
B0-silent
niklasad1
added
the
C1-low
| //! } | ||
| //! ``` | ||
| // jsonrpsee_proc_macros generates faulty warnings: https://github.com/paritytech/jsonrpsee/issues/106 |
There was a problem hiding this comment.
Would be good if you provide follow ups for this.
There was a problem hiding this comment.
it's fixed on master but I haven't done another release yet :)
…te-ext-jsonrpsee-show-kian
| uri: "http://localhost:9933".into(), | ||
| uri: TARGET.to_owned(), | ||
| rpc: Arc::new( | ||
| HttpClient::new( |
There was a problem hiding this comment.
This is wrong -- We can't initialize the client here. Then, if we override the at later, if will be a noop. Will push fixes.
There was a problem hiding this comment.
(or maybe it is correct -- have to check)
There was a problem hiding this comment.
ok, I didn't understand that thanks for the fix.
|
bot merge |
|
Waiting for commit status. |
|
Head SHA changed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
Fixes #8038 (comment) which replaces
jsonrpc-core-clientwithjsonrpsee-http-clientand doesn't requiretokio 0.1