Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

ModuleId to PalletId - part of #8372 #8477

Merged
8 commits merged into from
Apr 9, 2021
Merged

ModuleId to PalletId - part of #8372 #8477

8 commits merged into from
Apr 9, 2021

Conversation

@aurexav
Copy link
Contributor

@aurexav aurexav commented Mar 29, 2021 •
edited
Loading

Related #8372

Polkadot companion: paritytech/polkadot#2835

@thiolliere

@aurexav aurexav requested a review from kianenigma as a code owner March 29, 2021 03:06
@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 29, 2021
kianenigma
kianenigma reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't put PalletId in sp-.

gui1117
gui1117 approved these changes Mar 29, 2021
View reviewed changes
@gui1117
Copy link
Contributor

gui1117 commented Mar 29, 2021

I think we shouldn't put PalletId in sp-.

Maybe it should be moved to frame-support, I don't know why it is in primitives considering client doesn't need it.

@bkchr
Copy link
Member

bkchr commented Mar 29, 2021

Yeah @AurevoirXavier please move PalletId to frame-support.

@aurexav
Copy link
Contributor Author

aurexav commented Mar 30, 2021

Yeah @AurevoirXavier please move PalletId to frame-support.

Where should I place it? Currently I place it on the frame-support's root (lib.rs)

@gui1117
Copy link
Contributor

gui1117 commented Mar 30, 2021

root is ok to me, but compilation needs to be fixed

@aurexav
Copy link
Contributor Author

aurexav commented Mar 30, 2021

root is ok to me, but compilation needs to be fixed

On the way.

Also a companion for polkadot.

@aurexav
Copy link
Contributor Author

aurexav commented Apr 7, 2021

@thiolliere I also change the subcommand moduleid to palletid

@aurexav aurexav force-pushed the xavier-pallet-id branch from c177e1d to 36eb978 Compare April 7, 2021 02:54
@bkchr
Copy link
Member

bkchr commented Apr 7, 2021

@AurevoirXavier this requires a polkadot companion.

@aurexav aurexav mentioned this pull request Apr 7, 2021
Closed
@aurexav
Copy link
Contributor Author

aurexav commented Apr 7, 2021

@AurevoirXavier this requires a polkadot companion.

Done

@bkchr bkchr requested a review from kianenigma April 7, 2021 10:06
@shawntabrizi
Copy link
Member

shawntabrizi commented Apr 9, 2021

bot merge

@ghost
Copy link

ghost commented Apr 9, 2021

Trying merge.

@ghost ghost merged commit 35b74db into paritytech:master Apr 9, 2021
@c410-f3r c410-f3r mentioned this pull request Apr 12, 2021
Closed
@aurexav aurexav deleted the xavier-pallet-id branch April 13, 2021 03:25
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
@aurexav @hirschenberger
ModuleId to PalletId - part of paritytech#8372 (paritytech#8477)
8e5ed65 
* `ModuleId` to `PalletId` - part of paritytech#8372

* fix doc

* move `PalletId` to `frame-support`

* fix compile

* fix tests

* `ModuleId` to `PalletId`

* subcommand `moduleid` to `palletid`
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 20, 2021
@aurexav @jordy25519
ModuleId to PalletId - part of paritytech#8372 (paritytech#8477)
200dd58 
* `ModuleId` to `PalletId` - part of paritytech#8372

* fix doc

* move `PalletId` to `frame-support`

* fix compile

* fix tests

* `ModuleId` to `PalletId`

* subcommand `moduleid` to `palletid`
@aurexav aurexav mentioned this pull request Dec 11, 2024
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kianenigma kianenigma Awaiting requested review from kianenigma

3 more reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@bkchr bkchr bkchr approved these changes

@gui1117 gui1117 gui1117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aurexav @gui1117 @bkchr @shawntabrizi @kianenigma