Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Make it possible to override maximum payload of RPC #9019

Merged
14 commits merged into from
Jun 17, 2021
Merged

Make it possible to override maximum payload of RPC #9019

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b76dcf4
Make it possible to override maximum payload of RPC
kianenigma Jun 4, 2021
7b588f7
Finish it.
kianenigma Jun 4, 2021
52e474a
remove todo.
kianenigma Jun 4, 2021
d477996
Update client/cli/src/commands/run_cmd.rs
bkchr Jun 4, 2021
2bde5a7
Apply suggestions from code review
emostov Jun 16, 2021
dda8b09
Apply suggestions from code review
emostov Jun 17, 2021
ce04e83
Incorporate suggestions
emostov Jun 17, 2021
114315d
Merge remote-tracking branch 'origin' into kiz-override-max-payload
emostov Jun 17, 2021
24eaa76
Thread rpc_max_payload from configuration to trace_block
emostov Jun 17, 2021
ba7ecdb
Try obey line gitlab/check_line_width.sh
emostov Jun 17, 2021
6688329
update state rpc tests
emostov Jun 17, 2021
a6d69de
Improve readbility
emostov Jun 17, 2021
1387729
Apply suggestions from code review
emostov Jun 17, 2021
cd82ff8
Apply suggestions from code review
emostov Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove todo.
  • Loading branch information
@kianenigma
kianenigma committed Jun 4, 2021
commit 52e474ae667a179d713b623dddb6013a5402e548
2 changes: 1 addition & 1 deletion client/tracing/src/block/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ impl<Block, Client> BlockExecutor<Block, Client>
tracing::debug!(target: "state_tracing", "Captured {} spans and {} events", spans.len(), events.len());

let approx_payload_size = BASE_PAYLOAD + events.len() * AVG_EVENT + spans.len() * AVG_SPAN;
let response = if approx_payload_size > DEFAULT_MAX_PAYLOAD { // TODO
let response = if approx_payload_size > DEFAULT_MAX_PAYLOAD {
Comment thread
emostov marked this conversation as resolved.
Outdated
Comment thread
emostov marked this conversation as resolved.
Outdated
TraceBlockResponse::TraceError(TraceError {
error:
"Payload likely exceeds max payload size of RPC server.".to_string()
Expand Down