Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Suggestions for #9081 (Store voters in unsorted bags) #9328

Merged
emostov merged 26 commits into from
Jul 21, 2021
Merged

Suggestions for #9081 (Store voters in unsorted bags) #9328

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
01a04cc
Add some debug asserts to node::get and remove_node
emostov Jul 11, 2021
a37e59d
Improve the debug asserts in remove_node
emostov Jul 12, 2021
f047cec
improve debug asserts
emostov Jul 12, 2021
84dfba2
Space
emostov Jul 12, 2021
f0e754f
Remove bad assertions
emostov Jul 12, 2021
aceb642
Tests: WIP take_works
emostov Jul 12, 2021
19eb44f
Take test
emostov Jul 12, 2021
89f5319
Doc comment
emostov Jul 12, 2021
65e3bb3
Apply suggestions from code review
emostov Jul 12, 2021
57b9004
Test storage is cleaned up;
emostov Jul 14, 2021
2b5d9c8
formatting
emostov Jul 14, 2021
33ba6fb
Switch to simpler thresholds
emostov Jul 14, 2021
21f77eb
Update the storage cleanup test
emostov Jul 14, 2021
2e2fada
Remove hardcoded values from benchmark to make it more robust
emostov Jul 15, 2021
3dc2e52
Fix tests to acces bags properly
emostov Jul 15, 2021
e0dfed0
Sanity check WIP; tests failing
emostov Jul 15, 2021
f1f25f4
Update sanity checks to be more correct
emostov Jul 15, 2021
90a04d0
Improve storage cleanup tests
emostov Jul 15, 2021
c466c95
WIP remote_ext_tests
emostov Jul 16, 2021
fd907c6
Some notes on next steps
emostov Jul 16, 2021
a626db0
Remove some stuff that was for remote-ext tests
emostov Jul 19, 2021
2e9c6d9
Some more cleanup to reduce diff
emostov Jul 19, 2021
8deedee
More :clean:
emostov Jul 19, 2021
8c9c736
Mo cleanin
emostov Jul 19, 2021
4645325
small fix
emostov Jul 19, 2021
1f3c154
A lot of changes from kian
kianenigma Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some notes on next steps
  • Loading branch information
@emostov
emostov committed Jul 16, 2021
commit fd907c6e2440cdae44be9f1c61e90791d0520c6e
6 changes: 5 additions & 1 deletion frame/staking/src/remote_ext_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ async fn test_voter_bags_migration() {
.unwrap();

ext.execute_with(|| {
// regenerate ...
// - check existing data ??
// - regenerate ...
// - check regenerated data
// - stats on how each bag is occupied?
// - use real thresholds ..
// any other test we need to ...
})

Expand Down