-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Rewrap all comments to 100 line width #9490
Conversation
|
I did not review all files (obviously) but from what I have seen it does improve the visual appearance. |
gilescope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally in favor of us turning this on. I think it has more merit than the reformatting strings flag and on the whole looks to do more good than harm but there are definitely (highlighted) places where we need to opt out of the auto-formatting somehow.
|
@gilescope good catch. The trick is simply wrap anything in ", ', or ` and it will not automatically wrap, which seems like a correct thing to do anyway. |
|
@gilescope I belive I have addressed all your issues, except a handful of ones that I didn't resolve. I am still strongly for this change. Most of the things that we had to fix manually are either code snippets, which can be |
24f62b6 to
b5cc0e4
Compare
expenses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% of these changes look great :D ! But the remaining 1% do not. I think you'll need to manually change a few comments and then re-format.
expenses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really to review the whole thing again, but I think that if you ran cargo +nightly fmt again it should be good to go.
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
|
Waiting for commit status. |
Closes #6222
This makes the code much more readable for anyone who has visual rules in their editor, and just much more appealing over all.
I have to go through them once and revert maybe the links and bash commands in comments.