Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Ignore jsonrpc-* in dependabot #9518

Merged
bkchr merged 1 commit into from
Aug 9, 2021
Merged

Ignore jsonrpc-* in dependabot #9518

bkchr merged 1 commit into from
Aug 9, 2021

Conversation

@athei
Copy link
Member

@athei athei commented Aug 9, 2021

It seems that we are not going to upgrade this dependency but rather wait for jsonrpsee. In the meantime the PRs raised by dependabot are somewhat annoying. This disables them.

@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 9, 2021
@athei athei requested a review from a team as a code owner August 9, 2021 07:14
@athei athei requested review from andresilva and dvdplm August 9, 2021 07:39
TriplEight
TriplEight approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkchr bkchr merged commit f2b3997 into master Aug 9, 2021
@bkchr bkchr deleted the at-ignore-deps branch August 9, 2021 11:01
@athei athei mentioned this pull request Aug 12, 2021
Merged
bkchr added a commit that referenced this pull request Aug 12, 2021
@bkchr
Revert "Tell dependabot to ignore jsonrpc-* updates (#9518)"
20b0f76 
This reverts commit f2b3997.
ghost pushed a commit that referenced this pull request Aug 13, 2021
@bkchr
Upgrade jsonrpc to 0.18.0 (#9547)
7342a2f 
* Upgrade jsonrpc to 0.18.0

I think this says all :P

* 🤦

* Fmt etc

* Fix tests

* Fix tests again...

* Better impl

* Revert "Tell dependabot to ignore jsonrpc-* updates (#9518)"

This reverts commit f2b3997.
chevdor pushed a commit that referenced this pull request Sep 7, 2021
@bkchr @chevdor
Upgrade jsonrpc to 0.18.0 (#9547)
149b68f 
* Upgrade jsonrpc to 0.18.0

I think this says all :P

* 🤦

* Fmt etc

* Fix tests

* Fix tests again...

* Better impl

* Revert "Tell dependabot to ignore jsonrpc-* updates (#9518)"

This reverts commit f2b3997.
@chevdor chevdor mentioned this pull request Sep 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvdplm dvdplm Awaiting requested review from dvdplm

@andresilva andresilva Awaiting requested review from andresilva

2 more reviewers

@bkchr bkchr bkchr approved these changes

@TriplEight TriplEight TriplEight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@athei @bkchr @TriplEight