This repository was archived by the owner on Nov 15, 2023. It is now read-only.
upgrade simnet tests to v8 #9573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriplEight
suggested changes
Aug 17, 2021
Contributor
|
please write a PR description as well |
radupopa2010
added
A0-please_review
TriplEight
suggested changes
Aug 18, 2021
Co-authored-by: Denis Pisarev <[email protected]>
TriplEight
approved these changes
Aug 18, 2021
Contributor
TriplEight
left a comment
TriplEight
left a comment
There was a problem hiding this comment.
good to go. Please merge as pipeline gets green and ping me to change the version variable in gitlab.
Also, please note to change that comment.
grbIzl
approved these changes
Aug 18, 2021
TriplEight
reviewed
Aug 18, 2021
.gitlab-ci.yml
Outdated
| - if: $CI_PIPELINE_SOURCE == "schedule" | ||
| - if: $CI_COMMIT_REF_NAME == "master" | ||
| - if: $CI_COMMIT_REF_NAME =~ /^v[0-9]+\.[0-9]+.*$/ # i.e. v1.0, v2.1rc1 | ||
| variables: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade tests to simnet v8. This new version uses config for tests that live in this repo: https://github.com/paritytech/substrate/tree/master/simnet_tests.
At the moment tests run on a nightly schedule, on the master branch.
We have 2 kind of tests: "quick" and "long".
A "quick" test is a smoke test where basic check-expect tests run by checking values from metrics exposed by the app.
A "long" test is the load testing where we send 50K transactions into the network and check if all completed successfully.
We will do followup PR where we will run qucik test for all commits.