Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@athei
Copy link
Member

@athei athei commented Aug 30, 2021

Running cargo check --features runtime-benchmarks led to a compilation error when executed inside the pallet contracts directory. This was due to missing propagation of the std feature in some cases. This PR fixes that.

credits to @thiolliere for figuring that out

@athei athei added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Aug 30, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Aug 31, 2021

Trying merge.

@ghost ghost merged commit 856d0bd into master Aug 31, 2021
@ghost ghost deleted the at-fix-contracts-compilation branch August 31, 2021 04:11
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants